6:29 p.m.
https://bugs.meego.com/show_bug.cgi?id=18864
Summary: Config names become lowercase
Classification: MeeGo Platform
Product: OS Middleware
Platform: ---
Version: 1.2
Platform: Common
Architecture: ---
Status: NEW
Severity: normal
Priority: Undecided
Component: SyncEvolution
AssignedTo: patrick.ohly(a)intel.com
ReportedBy: gabriel.schulhof(a)intel.com
QAContact: jingke.zhang(a)intel.com
CC: syncevolution-bugs(a)meego.bugs,
ext-iekku.huttunen(a)nokia.com
Estimated Hours: 0.0
Version: syncevolution master@a38c914087e9eadad7bff91279fc19ae99e7a11c
Procedure:
Server.StartSession("Google_Contacts")
Session.SetConfig(false, false,
same_config_as_Google_Contacts_template_plus_username_and_password)
Session.Detach()
Server.GetConfigs(false)
At this point, it will list a config named "google_contacts" ...
If this is intentional, that's fine, and please close the bug.
--------
Product: OS Middleware
Component: SyncEvolution
MeeGo Release: 1.2
Severity: normal
Priority: Undecided
Keywords:
Status: NEW
Who: gabriel.schulhof(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=18864
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
8:19 p.m.
New subject: [Bug 18864] Config names become lowercase
https://bugs.meego.com/show_bug.cgi?id=18864
Jussi Kukkonen <jku(a)linux.intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jku(a)linux.intel.com
--- Comment #1 from Jussi Kukkonen <jku(a)linux.intel.com> 2011-06-13 10:19:14 UTC
---
So to give a little context to this:
WebDAV templates are named e.g. Google_Contacts. We want to be able to "match"
a configuration to a template (so the UI can avoid showing a Google Contacts
template when a Google Contacts config already exists).
I did not remember this when we discussed with Gabriel but it looks like we
(Patrick and me) have agreed at some point that the matchign happens _case
insensitively_ with config names -- at least this is what the GTK ui does. So
"google_calendar" config hides "Google_Calendar" template.
Is this ok with you Gabriel? Resolve INVALID?
--------
Product: OS Middleware
Component: SyncEvolution
MeeGo Release: 1.2
Severity: trivial
Priority: Low
Keywords:
Status: NEW
Who: jku(a)linux.intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed: CC
--------
https://bugs.meego.com/show_bug.cgi?id=18864
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
8:46 p.m.
New subject: [Bug 18864] Config names become lowercase
https://bugs.meego.com/show_bug.cgi?id=18864
--- Comment #2 from pohly <patrick.ohly(a)intel.com> 2011-06-13 10:46:47 UTC ---
Jussi, didn't we also agree that the UI should set the PeerName property if not
already in the template?
For example, the user might have chosen "XYZ/ foo bar" as config name (can
happen with a phone). Such a config name is valid in StartSession() as an alias
for the normalized version of the config name, which happens to be xyz_foo_bar
(lower case, special characters replaced by underscore).
This "normal form" is *not* something that the UI should know or care about!
Consider it an implementation detail.
That the GTK-UI emulates the normalization by doing a case-insensitive
comparison IMHO is a historic artifact. The correct solution would be:
- retrieve template
- set PeerName to the name of the template, if no PeerName is set
- save
- retrieve config
- compare PeerName against template name
--------
Product: OS Middleware
Component: SyncEvolution
MeeGo Release: 1.2
Severity: trivial
Priority: Low
Keywords:
Status: NEW
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=18864
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:33 p.m.
New subject: [Bug 18864] Config names become lowercase
https://bugs.meego.com/show_bug.cgi?id=18864
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2011-06-14 07:33:09 UTC ---
(In reply to comment #2)
That the GTK-UI emulates the normalization by doing a
case-insensitive
comparison IMHO is a historic artifact.
I remembered one case in favor of case-insensitive: configs created by users
via the command line do not necessarily (never?) have a PeerName. So
case-insensitive comparison makes sense *in combination* with checking the
PeerName.
--------
Product: OS Middleware
Component: SyncEvolution
MeeGo Release: 1.2
Severity: trivial
Priority: Low
Keywords:
Status: NEW
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=18864
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:27 p.m.
New subject: [Bug 18864] Config names become lowercase
https://bugs.meego.com/show_bug.cgi?id=18864
--- Comment #4 from Jussi Kukkonen <jku(a)linux.intel.com> 2011-06-14 08:27:04 UTC
---
(In reply to comment #2)
Jussi, didn't we also agree that the UI should set the PeerName
property if not
already in the template?
We may have done that...
The correct solution would be:
- retrieve template
- set PeerName to the name of the template, if no PeerName is set
- save
- retrieve config
- compare PeerName against template name
I guess this requires calling GetConfig for all templates and configs before
showing the list of configs/templates...
Just to be clear: do you mean we need to
1. match configuration PeerName to template PeerName if both exist
2. match configuration PeerName to template name if the peerName exists
3. match configuration name to template name (insensitively)
I tried looking this up but my mail archive probably doesn't go far enough: Do
you remember what was the reason for not doing just #3? and why not allow
CamelCase config names?
--------
Product: OS Middleware
Component: SyncEvolution
MeeGo Release: 1.2
Severity: trivial
Priority: Low
Keywords:
Status: NEW
Who: jku(a)linux.intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=18864
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
10:13 p.m.
New subject: [Bug 18864] Config names become lowercase
https://bugs.meego.com/show_bug.cgi?id=18864
--- Comment #5 from pohly <patrick.ohly(a)intel.com> 2011-06-14 12:13:31 UTC ---
(In reply to comment #4)
I guess this requires calling GetConfig for all templates and configs
before
showing the list of configs/templates...
Just to be clear: do you mean we need to
1. match configuration PeerName to template PeerName if both exist
2. match configuration PeerName to template name if the peerName exists
3. match configuration name to template name (insensitively)
Sounds right to me.
I tried looking this up but my mail archive probably doesn't go
far enough: Do
you remember what was the reason for not doing just #3?
It would have pushed the responsibility of picking a "safe" configuration name
into the UI. It would have to know that a config name like "foo/bar" is invalid
(because the slash would conflict with the mapping to the config files in the
file system).
Instead of defining "safe" config names, we picked the approach where the
syncevo-dbus-server sanitizes the chosen config name. That allows changing the
sanitization later on, for example when using a different config storage.
All that the UI needs to know is that a config name may have several aliases
which all map to the same config.
and why not allow
CamelCase config names?
Doesn't work well on the command line - IMHO.
--------
Product: OS Middleware
Component: SyncEvolution
MeeGo Release: 1.2
Severity: trivial
Priority: Low
Keywords:
Status: NEW
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=18864
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
10:44 p.m.
New subject: [Bug 18864] Config names become lowercase
https://bugs.meego.com/show_bug.cgi?id=18864
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |WORKSFORME
--- Comment #6 from pohly <patrick.ohly(a)intel.com> 2011-06-21 12:44:36 UTC ---
Closing as discussed on chat.
--------
Product: OS Middleware
Component: SyncEvolution
MeeGo Release: 1.2
Severity: trivial
Priority: Low
Keywords:
Status: RESOLVED
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed: Status Resolution
--------
https://bugs.meego.com/show_bug.cgi?id=18864
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4107
days inactive
4118
days old
syncevolution-issues@syncevolution.org
6 comments
1 participants
participants (1)
-
bugzilla＠meego.com