11:21 a.m.
http://bugs.meego.com/show_bug.cgi?id=6898
Summary: Backend: notebook missing in KCal backend
Classification: MeeGo Projects
Product: SyncEvolution
Version: unspecified
Platform: All
Architecture: ---
Status: NEW
Severity: normal
Priority: Medium
Component: SyncEvolution
AssignedTo: qiankun.miao(a)intel.com
ReportedBy: qiankun.miao(a)intel.com
QAContact: jingke.zhang(a)intel.com
CC: syncevolution-bugs(a)meego.bugs,
syncevolution-default-bugs(a)meego.bugs
Estimated Hours: 0.0
Now, notebook is not available in KCal backend. Notebook can be used to
distinguish different types of calender/todo. It describes an item and allows
operating many items with the same notebook meanwhile. Items can be saved into
different databases according its notebook, which is useful.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
10:04 p.m.
New subject: [MeeGo Projects - Bug 6898] Backend: notebook missing in KCal backend
http://bugs.meego.com/show_bug.cgi?id=6898
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |patrick.ohly(a)intel.com
Target Milestone|1.1 |1.2
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2010-09-25 06:04:52 PDT ---
Not needed for 1.1. Postponing to 1.2.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3:24 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #2 from qkmiao <qiankun.miao(a)intel.com> 2010-09-27 23:24:21 PDT ---
I pushed notebook name implementation into kcal-notebook branch. Patrick, could
you help to review and merge to master.
btw. When I did test, I found importing syncevolution/test/testcases/ical20.ics
made only one data item with uid:20060416T204647Z-4272-727-1-248%40gollum-rid
saved to storage. This exists in current syncevolution. Is it a bug in
syncevolution?
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:28 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2010-09-29 02:28:20 PDT ---
(In reply to comment #2)
I pushed notebook name implementation into kcal-notebook branch.
Patrick, could
you help to review and merge to master.
Looking at it now.
btw. When I did test, I found importing
syncevolution/test/testcases/ical20.ics
made only one data item with uid:20060416T204647Z-4272-727-1-248%40gollum-rid
saved to storage. This exists in current syncevolution. Is it a bug in
syncevolution?
How did you import? With --import syncevolution/test/testcases/ical20.ics?
CLIENT_TEST_SERVER=scheduleworld ./client-test
Client::Source::kcal_ical20::testImport
uses that file and does import more than one item, but there are known issues.
See bug #6049.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:34 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #4 from pohly <patrick.ohly(a)intel.com> 2010-09-29 02:34:05 PDT ---
(In reply to comment #3)
> btw. When I did test, I found importing
syncevolution/test/testcases/ical20.ics
> made only one data item with uid:20060416T204647Z-4272-727-1-248%40gollum-rid
> saved to storage. This exists in current syncevolution. Is it a bug in
> syncevolution?
How did you import? With --import syncevolution/test/testcases/ical20.ics?
I can reproduce that this only imports the first item. The reason is that
splitting at \n\n (blank line) fails for this file, which uses \r\n as line
ends.
I'll create a new issue for this.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:48 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #5 from pohly <patrick.ohly(a)intel.com> 2010-09-29 02:48:26 PDT ---
(In reply to comment #4)
I can reproduce that this only imports the first item. The reason is
that
splitting at \n\n (blank line) fails for this file, which uses \r\n as line
ends.
I'll create a new issue for this.
See bug #7664.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
8:53 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #6 from pohly <patrick.ohly(a)intel.com> 2010-09-29 04:53:37 PDT ---
(In reply to comment #2)
I pushed notebook name implementation into kcal-notebook branch.
Patrick, could
you help to review and merge to master.
I don't think we should create Notebooks inside of our backend. Every small
typo would lead to the creation of a new Notebook.
Traditionally, "evolutionsource" has only created something if there was an
explicit file:// prefix. If supported, the result was a database file at the
location following the prefix.
I suggest to do the same with the KCalExtended backend: with file://,
instantiate a SqliteStorage at that place. Without file://, search for an
existing Notebook with the given name in the default storage. If empty, use
default Notebook in default storage. This behavior should fit the needs of most
users and of the automated testing (which uses the file:// prefix).
This needs to be documented in the description of mkcal
(KCalExtendedRegister.cpp):
"mkcal = KCalExtended = calendar\n"
" iCalendar 2.0 = text/calendar\n"
" \"evolutionsource\" either refers to an
existing\n"
" calendar inside the default calendar storage or,\n"
" if it starts with the file:// prefix, to the\n"
" default calendar in that file. The file will be\n"
" created if it does not exist yet.\n",
Also please implement listing of existing Notebooks ("syncevolution" without
arguments, KCalExtendedSource::getDatabases()).
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:17 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #7 from qkmiao <qiankun.miao(a)intel.com> 2010-09-29 20:17:30 PDT ---
(In reply to comment #6)
Without file://, search for an
existing Notebook with the given name in the default storage. If empty, use
default Notebook in default storage.
Does the give name here mean evolutionsource value without a prefix (file://)?
So, no creation of new notebook here.
This behavior should fit the needs of most
users and of the automated testing (which uses the file:// prefix).
For automated testing, different database files could be used other than
different notebook name in the same database file. Right?
Then we avoid creating new notebook, but we create new database.
This needs to be documented in the description of mkcal
(KCalExtendedRegister.cpp):
"mkcal = KCalExtended = calendar\n"
" iCalendar 2.0 = text/calendar\n"
" \"evolutionsource\" either refers to an
existing\n"
" calendar inside the default calendar storage or,\n"
" if it starts with the file:// prefix, to the\n"
" default calendar in that file. The file will be\n"
" created if it does not exist yet.\n",
Also please implement listing of existing Notebooks ("syncevolution" without
arguments, KCalExtendedSource::getDatabases()).
Ok, I will add these two.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3:34 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #8 from pohly <patrick.ohly(a)intel.com> 2010-09-29 23:34:45 PDT ---
(In reply to comment #7)
(In reply to comment #6)
> Without file://, search for an
> existing Notebook with the given name in the default storage. If empty, use
> default Notebook in default storage.
Does the give name here mean evolutionsource value without a prefix (file://)?
So, no creation of new notebook here.
Yes. So evolutionsource=Personal would look for an existing Notebook with that
name.
>This behavior should fit the needs of most
> users and of the automated testing (which uses the file:// prefix).
For automated testing, different database files could be used other than
different notebook name in the same database file. Right?
Right. Both is possible, though. It'll depend on CLIENT_TEST_EVOLUTION_PREFIX.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4:39 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #9 from qkmiao <qiankun.miao(a)intel.com> 2010-09-30 00:39:13 PDT ---
(In reply to comment #6)
I don't think we should create Notebooks inside of our backend.
Every small
typo would lead to the creation of a new Notebook.
Traditionally, "evolutionsource" has only created something if there was an
explicit file:// prefix. If supported, the result was a database file at the
location following the prefix.
We may use KcalExtended in buteo. Tracker is used as database storage. I got
from yongsheng that no efficient approach to create two databases for two sync
clients. Using two notebooks is an alternative method. Typo issue still exists
when creating new database storage. So, I think maybe creation of new notebook
is also a feasible implementation.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4:58 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #10 from pohly <patrick.ohly(a)intel.com> 2010-09-30 00:58:53 PDT ---
(In reply to comment #9)
(In reply to comment #6)
> I don't think we should create Notebooks inside of our backend. Every small
> typo would lead to the creation of a new Notebook.
>
> Traditionally, "evolutionsource" has only created something if there was
an
> explicit file:// prefix. If supported, the result was a database file at the
> location following the prefix.
>
We may use KcalExtended in buteo. Tracker is used as database storage. I got
from yongsheng that no efficient approach to create two databases for two sync
clients.
Is it possible to select a Notebook for syncing with Buteo?
Using two notebooks is an alternative method. Typo issue still
exists
when creating new database storage.
Yes, but a casual user won't use the file:// semantic, and if he does make a
mistake when using it, he can remove the file. Removing a Notebook is harder
(impossible?!).
So, I think maybe creation of new notebook
is also a feasible implementation.
I agree that we need to make it work with Buteo, but I don't think that
SyncEvolution should create Notebooks. Can we move that functionality into a
separate utility?
That means that we can implement the evolutionsource as suggested in comment
#6.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:01 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #11 from pohly <patrick.ohly(a)intel.com> 2010-09-30 01:01:55 PDT ---
(In reply to comment #10)
> So, I think maybe creation of new notebook
> is also a feasible implementation.
I agree that we need to make it work with Buteo, but I don't think that
SyncEvolution should create Notebooks. Can we move that functionality into a
separate utility?
That means that we can implement the evolutionsource as suggested in comment
#6.
If we absolutely want to avoid the need for such an external tool, then we
could also do this:
- if the Notebook starts with some well-known prefix, like SyncEvolution_Test_,
then create it if it doesn't exist yet
- otherwise throw an error
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4:48 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #12 from qkmiao <qiankun.miao(a)intel.com> 2010-10-08 00:48:22 PDT ---
(In reply to comment #11)
(In reply to comment #10)
> > So, I think maybe creation of new notebook
> > is also a feasible implementation.
>
> I agree that we need to make it work with Buteo, but I don't think that
> SyncEvolution should create Notebooks. Can we move that functionality into a
> separate utility?
>
> That means that we can implement the evolutionsource as suggested in comment
> #6.
If we absolutely want to avoid the need for such an external tool, then we
could also do this:
- if the Notebook starts with some well-known prefix, like SyncEvolution_Test_,
then create it if it doesn't exist yet
- otherwise throw an error
This sounds well.
I will modify the fix according to comment 6 and comment 11.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:18 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
--- Comment #13 from qkmiao <qiankun.miao(a)intel.com> 2010-10-12 02:18:05 PDT ---
Partrick， I pushed the latest code to kcal-notebook branch. Could you help to
review it? Thanks!
1) support file://, SyncEvolution_Test_ prefix
2) add getDatabases() interface
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:50 p.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
yyin2 <yan.yin(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #14 from yyin2 <yan.yin(a)intel.com> 2010-11-04 01:50:22 PDT ---
sr 9195.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11:43 a.m.
New subject: [MeeGo Projects - Bug 6898] KCalExtended: select notebook (= evolutionsource)
http://bugs.meego.com/show_bug.cgi?id=6898
jingke <jingke.zhang(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RELEASED |VERIFIED
--- Comment #15 from jingke <jingke.zhang(a)intel.com> 2010-12-30 18:43:49 PST ---
Confirmed with Qiankun, the bug has been fixed now. Verify it.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3712
days inactive
3815
days old
syncevolution-issues@syncevolution.org
15 comments
1 participants
participants (1)
-
bugzilla＠meego.com