12:35 p.m.
https://bugs.freedesktop.org/show_bug.cgi?id=98529
Bug ID: 98529
Summary: invalid reference transfer on online account
authentication
Product: SyncEvolution
Version: unspecified
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
Component: SyncEvolution
Assignee: syncevolution-issues(a)syncevolution.org
Reporter: renatox(a)gmail.com
CC: syncevolution-issues(a)syncevolution.org
authentication process is leaking reference during the authentication:
This happens in all logs. Perhaps this is wrong:
signon-accounts.cpp:
GVariantCXX sessionData(ag_auth_data_get_login_parameters(m_authData,
extraOptions), TRANSFER_REF);
According to
http://accounts-sso.gitlab.io/libaccounts-glib/AgAuthData.html#ag-auth-da...,
ag_auth_data_get_login_parameters() does not transfer ownership, so
the line above probably should be:
GVariantCXX
sessionData(g_variant_ref_sink(ag_auth_data_get_login_parameters(m_authData,
extraOptions)), TRANSFER_REF);
Not sure whether that has been broken all along or is due to an API
change. Alberto Mardegan wrote that code in SyncEvolution.
I see a commit which cleans up reference counting in libaccounts.
Perhaps the warning was not seen when writing the count because
ag_auth_data_get_login_parameters returned a GVariant where the ref
count already was too high, so decrementing once too often did no harm.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
10:07 a.m.
New subject: [Bug 98529] invalid reference transfer on online account authentication
https://bugs.freedesktop.org/show_bug.cgi?id=98529
Patrick Ohly <patrick.ohly(a)gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #1 from Patrick Ohly <patrick.ohly(a)gmx.de> ---
Fix included in master branch:
commit 59372771027ea98f59e42b2390263b077a71876c
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Thu Nov 3 00:50:26 2016 -0700
SignonAuthProvider: fix ref counting issue
The account data was unreferenced once too often, or rather, a suitable ref
count increase was missing. A debug build of glib detects that ("GLib:
g_variant_unref: assertion 'value->ref_count > 0' failed"), but
without
that
check the code might also crash.
diff --git a/src/backends/signon/signon-accounts.cpp
b/src/backends/signon/signon-accounts.cpp
index 488a0e6..3ea9074 100644
--- a/src/backends/signon/signon-accounts.cpp
+++ b/src/backends/signon/signon-accounts.cpp
@@ -165,7 +165,7 @@ private:
// so we have to use the "steal" variant to enable that assignment.
GVariantStealCXX resultData;
GErrorCXX gerror;
- GVariantCXX sessionData(ag_auth_data_get_login_parameters(m_authData,
extraOptions), TRANSFER_REF);
+ GVariantCXX
sessionData(g_variant_ref_sink(ag_auth_data_get_login_parameters(m_authData,
extraOptions)), TRANSFER_REF);
const char *mechanism = ag_auth_data_get_mechanism(m_authData);
PlainGStr buffer(g_variant_print(sessionData, true));
SE_LOG_DEBUG(NULL, "asking for authentication with method %s,
mechanism %s and parameters %s",
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
2066
days inactive
2068
days old
syncevolution-issues@syncevolution.org
1 comments
1 participants
participants (1)
-
bugzilla-daemon＠freedesktop.org