--- Comment #4 from Patrick Ohly <patrick.ohly(a)gmx.de> ---
Comment on attachment 109732
remove unrelated changes
Is the expectation that StartDate gets updated regularly by the user? When set
only once, the calendar will start to grow over time again, it will just start
I'm not sure how significant that will be and in which cases - a slow sync
The alternative would be to have a relative time and sync events falling into
the last n days, for example. When a synchronized event falls out of that time
range, it should (?) be removed locally. Not sure whether additional code is
needed to achieve that. The same situation occurs when the user moves the
startDate forward after having synchronized.
Another corner case is events created locally outside of the time range. I
suppose they shall and will be synchronized to the server. When they then get
edited on the server, is the change synced back?
The patch itself looks okay at first glance. "Leve it empty" is a type (should
be "Leave"). A comment that this is only implement for CalDAV would be useful.
registry.push_back() and sourcePropCalendarStartDate don't line up with the
rest of the surrounding code - were tabs used for formatting?
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.