2:09 p.m.
http://bugzilla.moblin.org/show_bug.cgi?id=9155
Summary: [1.0-snapshot] zyb uses scheduleworld template as its
template
Classification: Moblin Projects
Product: SyncEvolution
Version: upstream
Platform: Netbook
OS/Version: Moblin Linux
Status: NEW
Severity: normal
Priority: Undecided
Component: SyncEvolution
AssignedTo: patrick.ohly(a)intel.com
ReportedBy: jingke.zhang(a)intel.com
QAContact: jingke.zhang(a)intel.com
CC: syncevolution(a)lists.intel.com
When I test 1.0-snapshot package (0.9.99.1-5.1), I found the zyb used the wrong
template. It is same with scheduleworld's.
My steps:
===============
$ syncevolution -l zyb test
$ cd ~/.config/syncevolution/default/peers/test
$ cat config.ini
the URL is: syncURL = http://sync.scheduleworld.com/funambol/ds
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4:44 p.m.
New subject: [Bug 9155] [1.0-snapshot] zyb uses scheduleworld template as its template
http://bugzilla.moblin.org/show_bug.cgi?id=9155
Chen Congwu <congwu.chen(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |congwu.chen(a)intel.com
AssignedTo|patrick.ohly(a)intel.com |congwu.chen(a)intel.com
--- Comment #1 from Chen Congwu <congwu.chen(a)intel.com> 2010-01-20 21:44:22 PST
---
The problem is allow fuzzy based template picking for device sync (and now also
for http clients). For a http client, it always matches a default template from
the template system which then returned presumably.
see commit e9664adda8b1adc463dbf444a325322b3ea15ac2
Cofiguration template: requires exact match for http client
templatesconfiguration-template
diff --git a/src/syncevo/SyncConfig.cpp b/src/syncevo/SyncConfig.cpp
index cd15efc..482c33d 100644
--- a/src/syncevo/SyncConfig.cpp
+++ b/src/syncevo/SyncConfig.cpp
@@ -466,6 +466,7 @@ boost::shared_ptr<SyncConfig>
SyncConfig::createPeerTemplate(const string &serve
// case insensitive search for read-only file template config
string templateConfig(SyncEvolutionTemplateDir());
+ bool exactMatch = false;
// before starting another fuzzy match process, first try to load the
// template directly taking the parameter as the path
if (isDir (server) && TemplateConfig::isTemplateConfig(server)) {
@@ -505,6 +506,9 @@ boost::shared_ptr<SyncConfig>
SyncConfig::createPeerTemplate(const string &serve
// not found, avoid reading current directory by using one which doesn't exist
templateConfig = "/dev/null";
}
+ if (maxmatch == TemplateConfig::BEST_MATCH) {
+ exactMatch = true;
+ }
}
boost::shared_ptr<FileConfigTree> tree(new FileConfigTree(templateConfig,
"",
false));
@@ -569,7 +573,7 @@ boost::shared_ptr<SyncConfig>
SyncConfig::createPeerTemplate(const string &serve
source->setSync("two-way");
}
- if (isDir(templateConfig)) {
+ if (isDir(templateConfig) && exactMatch) {
// directory exists, check for icon?
if (config->getIconURI().empty()) {
ReadDir dir(templateConfig);
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:47 p.m.
New subject: [Bug 9155] [1.0-snapshot] zyb uses scheduleworld template as its template
http://bugzilla.moblin.org/show_bug.cgi?id=9155
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|Undecided |P1
Status|NEW |ASSIGNED
CC| |patrick.ohly(a)intel.com
Severity|normal |major
--- Comment #2 from pohly <patrick.ohly(a)intel.com> 2010-01-20 23:47:44 PST ---
(In reply to comment #1)
The problem is allow fuzzy based template picking for device sync
(and now also
for http clients).
Why does the template selection use a fuzzy search at all?
SyncConfig::createPeerTemplate() takes the name of a template, not a
<Manufacturer>_<Model> string.
I'm not convinced that it should do a fuzzy match. When a user has a typo in
the --template parameter, then he shouldn't silently end up using the wrong
template.
I also don't see it mentioned in the commit message of your template search
patch. It mentioned --template ?, but not that --template <foo> also works
differently from before. If you knowingly change exiting user interfaces or the
D-Bus API, then *always* describe this clearly.
Can we revert to the old behavior?
Also, looking at the code again, the directory walking in
SyncConfig::createPeerTemplate() seems to be very similar (identical?) to the
one in SyncConfig::matchPeerTemplates(). Can the common code be put into an
utility function?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:15 p.m.
New subject: [Bug 9155] [1.0-snapshot] zyb uses scheduleworld template as its template
http://bugzilla.moblin.org/show_bug.cgi?id=9155
--- Comment #3 from Chen Congwu <congwu.chen(a)intel.com> 2010-01-21 00:15:22 PST
---
(In reply to comment #2)
(In reply to comment #1)
> The problem is allow fuzzy based template picking for device sync (and now also
> for http clients).
Why does the template selection use a fuzzy search at all?
SyncConfig::createPeerTemplate() takes the name of a template, not a
<Manufacturer>_<Model> string.
I'm not convinced that it should do a fuzzy match. When a user has a typo in
the --template parameter, then he shouldn't silently end up using the wrong
template.
I also don't see it mentioned in the commit message of your template search
patch. It mentioned --template ?, but not that --template <foo> also works
differently from before. If you knowingly change exiting user interfaces or the
D-Bus API, then *always* describe this clearly.
Can we revert to the old behavior?
I see, so that should be an exact match for
createPeerTemplate and fuzzy match
for matchPeerTemplate.
Also, looking at the code again, the directory walking in
SyncConfig::createPeerTemplate() seems to be very similar (identical?) to the
one in SyncConfig::matchPeerTemplates(). Can the common code be put into an
utility function?
I remembered I once intends to merge them and gave up. The code
then changed a
lot and reviewed it this time, they look exactly the same !? Have I missed
something?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
8:14 p.m.
New subject: [Bug 9155] [1.0-snapshot] zyb uses scheduleworld template as its template
http://bugzilla.moblin.org/show_bug.cgi?id=9155
--- Comment #4 from pohly <patrick.ohly(a)intel.com> 2010-01-21 01:14:49 PST ---
(In reply to comment #3)
(In reply to comment #2)
> Also, looking at the code again, the directory walking in
> SyncConfig::createPeerTemplate() seems to be very similar (identical?) to the
> one in SyncConfig::matchPeerTemplates(). Can the common code be put into an
> utility function?
I remembered I once intends to merge them and gave up. The code then changed a
lot and reviewed it this time, they look exactly the same !? Have I missed
something?
I'm not saying it is exactly the same, just similar. The code for iterating
over the directories and detecting those that are templates is the same. It
could be split out in two different ways:
- use a visitor pattern: code walks over directories and calls callback for
each
- build a list of directories, then iterate over that list
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
9:21 p.m.
New subject: [Bug 9155] [1.0-snapshot] zyb uses scheduleworld template as its template
http://bugzilla.moblin.org/show_bug.cgi?id=9155
--- Comment #5 from Chen Congwu <congwu.chen(a)intel.com> 2010-01-21 02:21:00 PST
---
(In reply to comment #4)
I changed matchPeerTemplate to add another "fuzzy" parameter which defaults to
true. If fuzzy is false, the match will only collect "exact match" and will
break as soon as possible. This is used by createPeerTemplate().
Pushed to configuration-template Is this OK?
I'm not saying it is exactly the same, just similar. The code for
iterating
over the directories and detecting those that are templates is the same. It
could be split out in two different ways:
- use a visitor pattern: code walks over directories and calls callback for
each
- build a list of directories, then iterate over that list
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:40 p.m.
New subject: [Bug 9155] [1.0-snapshot] zyb uses scheduleworld template as its template
http://bugzilla.moblin.org/show_bug.cgi?id=9155
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #6 from pohly <patrick.ohly(a)intel.com> 2010-01-24 23:40:23 PST ---
(In reply to comment #5)
(In reply to comment #4)
I changed matchPeerTemplate to add another "fuzzy" parameter which defaults to
true. If fuzzy is false, the match will only collect "exact match" and will
break as soon as possible. This is used by createPeerTemplate().
Pushed to configuration-template Is this OK?
Merged.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:08 p.m.
New subject: [Bug 9155] [1.0-snapshot] zyb uses scheduleworld template as its template
http://bugzilla.moblin.org/show_bug.cgi?id=9155
ZhangJingke <jingke.zhang(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #7 from ZhangJingke <jingke.zhang(a)intel.com> 2010-01-25 22:08:25 PST
---
Verify this issue on package: syncevolution-gtk-0.9.99.2-3.1.moblin2.i586.rpm
(made in 2010-01-22).
zyb configuration can be set well according to zyb templates.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4618
days inactive
4623
days old
syncevolution-issues@syncevolution.org
7 comments
1 participants
participants (1)
-
bugzilla＠moblin.org