Re: [SyncEvolution] code review: credential checking

-----Original Message----- From: Ohly, Patrick Sent: Wednesday, November 04, 2009 3:41 PM To: Chen, Congwu Cc: SyncEvolution Subject: RE: code review: credential checking On Wed, 2009-11-04 at 06:29 +0000, Chen, Congwu wrote: > If I understand correctly, > There need a little more work on the "nonce" property: > It may contain "!" character but not used for escaping. > > The unescape procedure will remove such characters unexpectedly. That was indeed a problem when I tested the code. So you think the "SafeConfigNode::escape(): did not work correctly for strings with ! in them" patch doesn't solve that issue? Probably a unit test is due for that code. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter.