On Wed, Aug 3, 2011 at 5:58 PM, Patrick Ohly <patrick.ohly(a)intel.com> wrote:
On Mi, 2011-08-03 at 17:02 +0200, Chris Kühl wrote:
> I've been working on retrieving the immutable vendor and product id
> provided by the Bluetooth Device ID profile (DIP). See my
> bluetooth-device-id branch for what's been pushed so far.
> Being that we now have a means of getting reliable device information
> it seems to me that in the cases where this information was
> attainable, a matching score is no longer needed. If the fingerprint
> matches the product name from the look-up table exactly (and it will
> because we've created the lookup table and the template fingerprints)
> we suggest just that one template instead of several. If we didn't get
> this product name from the look-up table then everything should behave
> as normal because we can't trust the user-modifiable device name
> Does this sound reasonable or are there other reasons you'd want more
> than one template to choose from even when you're sure which device
> you're dealing with?
What about a Sony Ericcson phone which unknown product ID? We have two
templates for vendor=Sony Ericsson.
In this case it would work just as before. If the device supports the
Device ID profile but it's not in our look-up table of known devices
then we don't use it. We need the look-up table to get the product
There are 2 things that have to happen for the matching score to be unnecessary.
1) The device needs to be in the look-up table.
2) The template needs to have a fingerprint that matches the product
string from the look-up table exactly. If we or the user has added it
here then this should be the template to use.
If both are not fulfilled then we do as we've been doing.
I agree that if the vendor matches exactly one template, preferring
template makes sense. I can imagine corner cases where it is not the
right one (unknown Sony Ericsson phone which behaves like a Nokia), but
that should be unlikely. So we should take advantage of the more
reliable information to propose only one template.
If there is a Sony Ericsson that acts as a Nokia then the product id
should be in the Nokia template, right? Or we can just copy that
template and rename it which would probably more clear for the user.
With this I'm assuming that fingerprints are only added to templates
once the template is confirmed to be appropriate for that device.