Re: [SyncEvolution] [REVIEW REQUEST 1/7] pbap client: add skeleton
On Fr, 2012-01-27 at 14:55 +0100, Mikel Astiz wrote:
[...]
+static class VCard30Test : public RegisterSyncSourceTest {
+public:
+ VCard30Test() : RegisterSyncSourceTest("file_contact",
"eds_contact") {}
[...]
+ SuperTest() :
RegisterSyncSourceTest("file_calendar+todo", "calendar+todo") {}
Better don't register the tests. The first parameter of
RegisterSyncSourceTest() would have to be unique (say, "pbap_contact"),
but even then the test would mostly just fail because the source is not
implementing write access.
I'll commit my patch which removes that dead code later today.
+PbapSyncSource::Databases PbapSyncSource::getDatabases()
+{
+ Databases result;
+
+ result.push_back(Database("select database via bluetooth
address",
+ "[obex-bt://]<bt-addr>"));
+ return result;
+}
The obex-bt:// prefix is not optional, is it? The rest of the
documentation shows it as obligatory and the code agrees.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.