Re: [SyncEvolution] merging phone branch
Patrick wrote:
Hello!
I'm merging the "phone" branch, with changes for client-test testing of
syncing with the Nokia N7210c. Some comments...
ClientTest: Add a new test config for phones do not support UTC time.
Phones may not fully support UTC time. As the case for Nokia 7210c, it
can
understand the UTC time sent by server but will not convert it back to
UTC time
when sending back to server.
Use 'CLIENT_TEST_NOUTC' to use this special test configuration.
Your test data uses
TZID=/freeassociation.sourceforge.net/Tzfile/Asia/Shanghai. Will that
test work with phones using a different time zone?
No, it cannot. Testing phones
which do not support UTC time, we have to manually change
the timezone in our tests the same as the local timezone in phone.
"type" is a const char * pointer. You point it towards a temporary
std::string buffer, which will leave you with a dangling pointer that is
not necessarily still pointing to allocated memory! I'll fix this after
merging.
Congwu, review the patch in the "pohly" branch and merge if you agree.
While you are at it, please also review the other pending patches in
that branch.
Merged.
test/README.nokia_7210c: mentions the Google server. The rest of the
file was updated, I assume? ;-)
Yep, a typo.
Best Regards,
Congwu