Re: [SyncEvolution] Request: Install D-Bus interface XML files
On Tue, 2010-06-08 at 17:51 +0100, Sascha Peilicke wrote:
On Tuesday 08 June 2010 17:17:42 you wrote:
> On Fri, 2010-06-04 at 17:31 +0100, Sascha Peilicke wrote:
> On the other hand, some new methods and signals were not annotated yet
> by Carl. Further patches for those are welcome.
>
> > Also I had to change the parameter name 'template' of the GetConfig()
and
> > GetConfigs() methods of the session and server definition as this is a
> > keyword in C++ and won't compile. I simply changed it to
'templates'
> > (patch attached).
>
> That's also in Carl's patch, except that he renamed it to
"tmplate".
This maybe nit-picky but 'templates' maybe more appropriate, as the intend is
to return a list of strings.
But it only returns one config or template, never more than one. So I
still think singular "tmplate" is appropriate.
About installing the .xml files in /usr/share/dbus-1/interfaces, does
that still make sense? For example, which files should get installed -
with or without <annotation>, or both under different names? What about
<doc:*>?
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.