On Di, 2011-11-29 at 15:09 +0100, Chris Kühl wrote:
On Tue, Nov 29, 2011 at 2:31 PM, Patrick Ohly
> On Di, 2011-11-29 at 13:20 +0100, Chris Kühl wrote:
[patch with NULL check]
> Does that look right?
Seems fine to me.
I've merged your branch and applied the fix.
> Speaking of DBusErrorCXX, why does it have a separate
That's only in there to maintain compatibility. I believe the examples
were the only place the message field was used however. We could
easliy change those and get read of this member.
Yes, let's do that. I'm working on a patch.
Looking closer at compiler output, I saw a warning about this code:
class DBusResult : virtual public Result
virtual void failed(const dbus_error &error)
errMsg = g_dbus_message_new_method_error(m_msg.get(), error.dbusName().c_str(),
===> if (!g_dbus_connection_send_message(m_conn.get(), m_msg.get(),
G_DBUS_SEND_MESSAGE_FLAGS_NONE, NULL, NULL))
throw std::runtime_error(" g_dbus_connection_send_message failed");
gdbus-cxx-bridge.h: In member function 'virtual void
gdbus-cxx-bridge.h:1778:23: warning: variable 'errMsg' set but not used
Is errMsg the message which is meant to be sent above?
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.