11:45 a.m.
Hi,
syncevolution 1.5.2 fails to build with libical 3.0.0.
I attached a patch which makes it build. Let me know if anything is
wrong, please.
Thanks and bye,
Milan
8:13 p.m.
On Thu, 2017-11-16 at 12:45 +0100, Milan Crha wrote:
Hi,
syncevolution 1.5.2 fails to build with libical 3.0.0.
I attached a patch which makes it build. Let me know if anything is
wrong, please.
I've not forgotten about this. Thanks for the patch, I'll try it with
libical 3.0. The actual upstream patch inevitably will have to be more
complex (= more ifdefs), because SyncEvolution still needs to compile
for distros with older libical versions.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
2:59 p.m.
On Thu, 2017-11-16 at 12:45 +0100, Milan Crha wrote:
- itime = icaltime_from_timet (now, 0);
+ itime = icaltime_from_timet_with_zone (now, 0,
NULL);
Upstream replaced icaltime_from_timed(x, 0) with
icaltime_from_timet_with_zone(x, 0, icaltimezone_get_utc_timezone()).
Is that perhaps also what should be done in SyncEvolution? I haven't
tested whether it makes a difference yet.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
3:26 p.m.
On Thu, 2017-12-14 at 15:59 +0100, Patrick Ohly wrote:
On Thu, 2017-11-16 at 12:45 +0100, Milan Crha wrote:
> - itime = icaltime_from_timet (now, 0);
> + itime = icaltime_from_timet_with_zone (now, 0,
> NULL);
Upstream replaced icaltime_from_timed(x, 0)
with
icaltime_from_timet_with_zone(x, 0, icaltimezone_get_utc_timezone()).
Is that perhaps also what should be done in SyncEvolution?
No, internally icaltime_from_timed(x, 0) was implemented as
icaltime_from_timet_with_zone(x, 0, NULL), just like your patch does, s
that should be fine.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
1704
days inactive
1732
days old
syncevolution@synevolution.org
3 comments
2 participants
participants (2)
-
Milan Crha -
Patrick Ohly