[PATCH 1/1] Remove the access of status property of DataConnectionManager from oFono

Marcel Holtmann marcel at holtmann.org
Wed Apr 14 03:32:18 PDT 2010


Hi Martin,

> The status property has been removed from oFono post oFono 0.20
> ---
>  plugins/ofono.c |   12 ------------
>  1 files changed, 0 insertions(+), 12 deletions(-)
> 
> diff --git a/plugins/ofono.c b/plugins/ofono.c
> index 2ad01f2..2e47ce6 100644
> --- a/plugins/ofono.c
> +++ b/plugins/ofono.c
> @@ -777,11 +777,6 @@ static void check_networks_reply(DBusPendingCall *call, void *user_data)
>  			contexts = value;
>  			add_default_context(&contexts, path,
>  					CONTEXT_NAME, CONTEXT_TYPE);
> -		} else if (g_str_equal(key, "Status") == TRUE) {
> -			const char *status;
> -
> -			dbus_message_iter_get_basic(&value, &status);
> -			/* FIXME: add roaming support */
>  		} else if (g_str_equal(key, "Powered") == TRUE) {
>  			dbus_bool_t powered;
>  
> @@ -1377,13 +1372,6 @@ static gboolean gprs_changed(DBusConnection *connection, DBusMessage *message,
>  		else if (modem->device != NULL)
>  			connman_device_remove_all_networks(modem->device);
>  
> -	} else if (g_str_equal(key, "Status") == TRUE) {
> -		const char *status;
> -		dbus_message_iter_get_basic(&value, &status);
> -
> -		DBG("status %s", status);
> -
> -		/* FIXME: add roaming support */
>  	} else if (g_str_equal(key, "PrimaryContexts") == TRUE) {
>  		check_networks(modem);
>  	} else if (g_str_equal(key, "Powered") == TRUE) {

since we are actually never did anything useful with these, it is fine
to just remove them. For the other changed properties we need a nice
migration period where both are working out.

Patch has been applied. Thanks.

Regards

Marcel





More information about the connman mailing list