[PATCH v5] Add inotify monitoring .config file.

Marcel Holtmann marcel at holtmann.org
Wed Jan 5 14:11:52 PST 2011


Hi Mohamed,

> Reflect new and modify *.config to connman config list. with
> patch any modified or added .config file will be read by connman
> and add these configuration for new provisioning.
> ---
>  src/config.c |  171 +++++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  1 files changed, 163 insertions(+), 8 deletions(-)

this looks good now. Patch has been applied. Thanks.

> -			if (connman_dbus_validate_ident(ident) == TRUE)
> -				create_config(ident);
> +			if (connman_dbus_validate_ident(ident) == TRUE) {
> +				struct connman_config *config;
>  
> +				config = create_config(ident);
> +				if (config != 0)
> +					load_config(config);

I did have a minor issue here. You need to compare to != NULL in this
case and not to 0. While the compiler does the right thing, it should
have warned you at least.

Anyhow this was so simple, that I just fixed it up before applying the
patch :)

Regards

Marcel





More information about the connman mailing list