[PATCH resend v1] Fix missing and empty WiFi APs issue after kill/restart

Marcel Holtmann marcel at holtmann.org
Thu Jan 6 09:36:02 PST 2011


Hi Leena,

> When ConnMan is SIGKILLed and restarted WiFi plugin will reuse the
> existing interface and the BSSs list. For BSSs list the next iterator
> contains the object path of next BSS but interface_bss_added() wrongly
> assumes that the next iterator contains the key/value pairs for the BSS
> properties and a GSupplicantNetwork is created with empty fields
> resulting in and empty AP list.
> 
> Also the iterator is moved to next by both interface_bss_added() and
> supplicant_dbus_array_foreach() resulting in not adding alternate
> BSSs from the list.
> 
> Fix gsupplicant interface_bss_added() to distinguish between BSS's added
> with/without the BSS properties.
> 
> Fixes BMC#10454 and #11201
> 
> ---
>  gsupplicant/supplicant.c |   56 +++++++++++++++++++++++++++++++++++----------
>  1 files changed, 43 insertions(+), 13 deletions(-)

I have to take this back. I can not apply your patch right away:

Applying: Fix missing and empty WiFi APs issue after kill/restart
/data/devel/connman/.git/rebase-apply/patch:71: trailing whitespace.
 
/data/devel/connman/.git/rebase-apply/patch:75: trailing whitespace.
	
fatal: 2 lines add whitespace errors.
Patch failed at 0001 Fix missing and empty WiFi APs issue after kill/restart

So please fix these and also the two other minor nitpicks I mentioned
earlier.

Regards

Marcel





More information about the connman mailing list