[PATCH 1/3] Add vpnc support.

David Woodhouse dwmw2 at infradead.org
Sat Jan 15 17:29:33 PST 2011


On Sat, 2011-01-15 at 16:34 -0800, Mohamed Abbas wrote:
> 
> +static void vc_append_route(const char *key, const char *value,
> GHashTable *routes)
> +{
> +       struct vc_route *route;
> +       int type;
> +
> +       /*
> +        * VPNC pushes routing tupples (host, mask,masklen) as several
> +        * environment values, e.g.
> +        *
> +        * CISCO_SPLIT_INC_1_ADDR = 10.242.2.13
> +        * CISCO_SPLIT_INC_1_MASK = 255.255.0.0
> +        *
> +        * The hash table is used to group the separate environment
> +
> +        * complete even when VPNC pushes the information in a
> +        * wrong order (unlikely).
> +        */ 

If we're starting to support split tunnel routing, can you implement it
for openconnect too? The environment variables are deliberately
identical between vpnc and openconnect.

On the OpenConnect side ∃ CISCO_IPV6_SPLIT_INC_* environment variables
(and INTERNAL_IP6_{ADDRESS,NETMASK}) too. But vpnc will be learning
about those just as soon as I get access to a suitable server. This is
2011, after all.

I note you have the same issue I called out in my own version — complete
lack of error handling should the connection fail to come up for
whatever reason. I understand that having no error handling is the norm
for MeeGo, and I know I committed the same offence in my original
openconnect support. But we really do need to do better :)

-- 
dwmw2




More information about the connman mailing list