[ofono-autoconnect RFC 6/9] Set reconnect when loading a favorite service

Pekka Pessi ppessi at gmail.com
Tue Jan 18 14:20:43 PST 2011


Hi Marcel,

2011/1/18 Marcel Holtmann <marcel at holtmann.org>:
>> +             if (service->favorite)
>> +                     set_reconnect_state(service, TRUE);
>> +
>
> the preference here is to do check explicitly for TRUE or FALSE.
>
>                if (service->favorite == TRUE)

Are you certain? That brings certain fragility. If you insist, I'd prefer

if (service->favorite != FALSE)

-- 
Pekka.Pessi mail at nokia.com



More information about the connman mailing list