[PATCH 00/16] WPS support (reviewed)

Samuel Ortiz sameo at linux.intel.com
Thu Jan 27 06:28:59 PST 2011


Hi Tomasz,

On Wed, Jan 26, 2011 at 10:09:29AM +0200, Tomasz Bursztyka wrote:
> Hi Samuel,
> 
> I adapted you comments on the patches. I hope it suits better now.
> I did not merged patch 11 to 7 though (I still think it is 2 different things)
> 
> Overall modifications seems bigger than before but it's not. It's due to a whole block of code moved in patch 6 (we talked about that on irc)
> 
> About wpa_supplicant stuff, I already send patches there (upstream) but one is still pending (the raw key issue). I might poke again about it.
> This "wps" keymgmt lack is indeed necessary. I already had a quick look on wpa_supplicant code (it's located in dbus_new_handlers.c:wpas_dbus_get_bss_security_prop()) but unfortunately it does not sound that trivial. (current code always send only one keymgmt method). Will have a look further.
> I am sending patches on dev branch (so 8.x version yes)
> 
> Br,
Looks good, all 16 patches applied. Thanks for your work.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/



More information about the connman mailing list