[PATCH 1/2] ippool: Add error and warning messages

Daniel Wagner wagi at monom.org
Mon Feb 20 02:13:33 PST 2012


From: Daniel Wagner <daniel.wagner at bmw-carit.de>

---
Monday morning problems....

This one should now be fine.

 src/ippool.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/ippool.c b/src/ippool.c
index 065c278..968d20f 100644
--- a/src/ippool.c
+++ b/src/ippool.c
@@ -353,12 +353,16 @@ struct connman_ippool *__connman_ippool_create(int index,
 	 * The range is at max 255 and we don't support overlapping
 	 * blocks.
 	 */
-	if (start + range > 254)
+	if (start + range > 254) {
+		connman_error("IP pool does not support pool size larger than 254");
 		return NULL;
+	}
 
 	block = get_free_block(start + range);
-	if (block == 0)
+	if (block == 0) {
+		connman_warn("Could not find a free IP block");
 		return NULL;
+	}
 
 	pool = g_try_new0(struct connman_ippool, 1);
 	if (pool == NULL)
-- 
1.7.9.48.g85da4d




More information about the connman mailing list