[PATCH 1/7] service: Add function for updating service types used by sessions

Patrik Flykt patrik.flykt at linux.intel.com
Fri Nov 2 05:59:54 PDT 2012


	Hi,

On Fri, 2012-11-02 at 10:54 +0100, Daniel Wagner wrote:
> Couldn't use something like
> 
> #define MAX_SERVICE CONNMAN_SERVICE_TYPE_GADGET + 1
> 
> and maybe also add a big comment to update the define if enum 
> connman_service_type grows (if you really want to go with the array)

I was thinking of introducing a MAX_SERVICE_TYPES or something into
services.h instead of this.

> VPN is also a valid bearer in the session core.

True, but VPN autoconnect handling might need to have a slightly
different logic since they need another service enabled in order to
work. I'll leave this part until we have Jukka's VPN patches in. Might
be that the VPN daemon does something here (or then not).

Cheers,

	Patrik




More information about the connman mailing list