[PATCH] types: Add global ARRAY_SIZE macro

Patrik Flykt patrik.flykt at linux.intel.com
Thu Nov 29 01:32:55 PST 2012


	Hi,

On Thu, 2012-11-29 at 11:21 +0200, Patrik Flykt wrote:
> 	Hi,
> 
> On Thu, 2012-11-29 at 09:20 +0100, Daniel Wagner wrote:
> > From: Daniel Wagner <daniel.wagner at bmw-carit.de>
> > 
> > There is no need to redefine this macro everywere.
> > ---
> >  include/types.h       | 2 ++
> >  plugins/iwmx.h        | 1 -
> >  vpn/plugins/l2tp.c    | 2 --
> >  vpn/plugins/openvpn.c | 2 --
> >  vpn/plugins/pptp.c    | 2 --
> >  vpn/plugins/vpnc.c    | 2 --
> >  6 files changed, 2 insertions(+), 9 deletions(-)
> 
> I think ARRAY_SIZE should be defined in vpn.h. Wimax support is EOL in a
> month and the rest of the users are all VPN plugins. Also types.h is
> included only indirectly and its usefulness is in practise limited to
> defining connman_bool_t.

Hrm, Johan just commented that there exists an G_N_ELEMENTS macro in
glib with the same very same definition already... and said plugins
include glib already.


	Patrik




More information about the connman mailing list