[PATCH 1/3] service: Substitute connman_uint8_t with unsigned char

Marcel Holtmann marcel at holtmann.org
Fri Nov 30 00:56:58 PST 2012


Hi Patrik,

> 'connman_uint8_t' is rarely used, use the real type instead.
> ---
>  src/service.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/service.c b/src/service.c
> index 67889de..1ad71d3 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -72,7 +72,7 @@ struct connman_service {
>  	enum connman_service_state state_ipv4;
>  	enum connman_service_state state_ipv6;
>  	enum connman_service_error error;
> -	connman_uint8_t strength;
> +	unsigned char strength;

I prefer if we start switching to uint8_t, uint16_t and also bool in the
code base.

Regards

Marcel





More information about the connman mailing list