[PATCH v3 00/21] VPN agent support

Jukka Rissanen jukka.rissanen at linux.intel.com
Fri Nov 30 01:30:33 PST 2012


Contains changes (bullets 1 + 2) reported by Patrik
- refactoring common code from openconnect.c, l2tp.c and pptp.c
  into vpn-agent.c, this is in patches 5 and 10
- check returned dbus types in openconnect.c (patch 6), l2tp.c
  (patch 11) and pptp.c (patch 12)
- noticed free memory access in generic vpn code, it was possible
  to access already freed memory if provider was removed and then
  recreated (patch 17)
- the patches 18-21 remove the user credentials when disconnecting,
  otherwise the user could reconnect to vpn without being asked
  any questions via agent

Fixes issues reported by Wagi (mainly splitting
patchset into smaller pieces). This set also adds L2TP
and PPTP username/password query from the agent.

Initial VPN agent support. This means that VPN plugin is able
to ask necessary questions from agent which will ask the
information from the user.


Jukka Rissanen (21):
  doc: Describe VPN agent API
  vpn: Add initial support for async connect
  vpn-provider: Add getter functions
  vpn: Make VPN plugin connection function async
  vpn-agent: Add generic functions to add information into agent dict
  openconnect: Add asking cookie from agent
  test: Add vpn agent support into simple-agent
  openconnect: Domain pointer was used incorrectly
  openconnect: Add support for --no-cert-check client option
  vpn-agent: Routine to add username and password into agent dict
  l2tp: Ask username and password from agent
  pptp: Ask username and password from agent
  l2tp: Do not save the password
  pptp: Do not save the password
  agent: Release all agents when stopping
  vpn-provider: Register agent driver
  vpn-provider: Unregister provider from dbus when freed
  vpn: Driver disconnect needs provider information
  openconnect: Clear cookie when disconnecting
  l2tp: Clear password when disconnecting
  pptp: Clear password when disconnecting

 Makefile.am               |   3 +-
 doc/vpn-agent-api.txt     | 137 ++++++++++++++++++++
 src/agent.c               |  22 +++-
 test/simple-agent         | 118 ++++++++++++++++-
 vpn/plugins/l2tp.c        | 277 ++++++++++++++++++++++++++++++++++++----
 vpn/plugins/openconnect.c | 315 ++++++++++++++++++++++++++++++++++++++++++----
 vpn/plugins/openvpn.c     |  14 ++-
 vpn/plugins/pptp.c        | 276 +++++++++++++++++++++++++++++++++++++---
 vpn/plugins/vpn.c         |   9 +-
 vpn/plugins/vpn.h         |   5 +-
 vpn/plugins/vpnc.c        |  18 ++-
 vpn/vpn-agent.c           | 144 +++++++++++++++++++++
 vpn/vpn-agent.h           |  46 +++++++
 vpn/vpn-provider.c        | 147 ++++++++++++++++------
 vpn/vpn-provider.h        |  19 ++-
 vpn/vpn.h                 |   2 +-
 16 files changed, 1434 insertions(+), 118 deletions(-)
 create mode 100644 doc/vpn-agent-api.txt
 create mode 100644 vpn/vpn-agent.c
 create mode 100644 vpn/vpn-agent.h


More information about the connman mailing list