[PATCH v3 00/21] VPN agent support

Patrik Flykt patrik.flykt at linux.intel.com
Fri Nov 30 05:18:25 PST 2012


On Fri, 2012-11-30 at 11:30 +0200, Jukka Rissanen wrote:
> Hi,
> 
> v3:
> Contains changes (bullets 1 + 2) reported by Patrik
> - refactoring common code from openconnect.c, l2tp.c and pptp.c
>   into vpn-agent.c, this is in patches 5 and 10
> - check returned dbus types in openconnect.c (patch 6), l2tp.c
>   (patch 11) and pptp.c (patch 12)
> - noticed free memory access in generic vpn code, it was possible
>   to access already freed memory if provider was removed and then
>   recreated (patch 17)
> - the patches 18-21 remove the user credentials when disconnecting,
>   otherwise the user could reconnect to vpn without being asked
>   any questions via agent

Applied all but 19/21. I think the cookie can stay as long as the
openconnect vpn server lets it. If not, we can always apply 19/21 later.

There were an include file missing in 05/21 and another in 06/21, I
fixed those.

If a username is given when configuring, it will be saved. If not given
when configuring, it will not be saved. Let's verify if this is the
behavior we want.

Thanks,

	Patrik




More information about the connman mailing list