[edk2] [Patch] edk2 Readme.md: Add edk2 release tag and edk2 release plan
liming.gao at intel.com
Wed Dec 12 05:52:15 PST 2018
Sorry for the confuse. I don't find the good name for them. I think your suggestion is good. I will keep it.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces at lists.01.org] On Behalf Of Laszlo Ersek
> Sent: Wednesday, December 12, 2018 6:22 PM
> To: Gao, Liming <liming.gao at intel.com>; edk2-devel at lists.01.org
> Subject: Re: [edk2] [Patch] edk2 Readme.md: Add edk2 release tag and edk2 release plan
> Hi Liming,
> On 12/12/18 01:41, Gao, Liming wrote:
> > Hi, all
> > I don't get any comments on this change. So, I will push it this week.
> sorry that I didn't respond earlier.
> I think the structure of your patch series is confusing. The first patch
> is for the edk2 project README file. I saw that soon after you posted
> these patches, and I thought someone else should comment on the series.
> So I skipped the rest of the series as well.
> However, the second patch in the series (which is not numbered, but I
> can see the second patch was sent threaded under the first), is for the
> edk2 *wiki*. I think that's extremely confusing, modifying multiple
> *repositories* in a single patch email thread. The wiki patch should
> have been sent separately.
> Furthermore, the subject shouldn't be
> [edk2] [Patch] edk2 wiki: remove ...
> [edk2] [Patch edk2-wiki] remove ...
> For two reasons:
> - This way reviewers will see at once that the *project* (repo) in
> question is the wiki. We always put the repo (e.g. edk2-platforms,
> edk2-staging) in the bracketed part.
> - When the patch is finally pushed to the wiki, the subject line of the
> commit should not say "edk2 wiki". The commit is made to the wiki repo
> anyway, so naming it in the commit message is redundant.
> Anyway, beyond the above meta-comments, I'm fine with the contents of
> the patches themselves. The article at
> preserves the list of features added in the November release. That link
> is added to Readme.md in the first patch, and in general,
> <https://github.com/tianocore/edk2/releases> is a generic feature of
> github, for all projects.
> edk2-devel mailing list
> edk2-devel at lists.01.org
More information about the edk2-devel