[edk2] [PATCH edk2-platforms 00/11] final set of Styx cleanups

Leif Lindholm leif.lindholm at linaro.org
Wed Dec 12 14:23:19 PST 2018


On Tue, Dec 11, 2018 at 07:35:03PM +0100, Ard Biesheuvel wrote:
> I promise :-)

Yeah, right :)

> This gets rid of the last build config options passed via the command
> line into the preprocessor, and replaces them with PCD references.
> 
> Ard Biesheuvel (11):
>   Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes
>   Platform/SoftIron/Overdrive1000Board: remove dead XGBE references
>   Silicon/AMD/Styx/AcpiPlatformDxe: replace XGBE CPP conditional with
>     PCD
>   Silicon/AMD/Styx/PlatInitPei: replace XGBE CPP conditional with PCD
>   Silicon/AMD/Styx/StyxDtbLoaderLib: replace XGBE CPP conditional with
>     PCD
>   Platform/AMD/OverdriveBoard: drop DO_XGBE C preprocessor defines
>   Silicon/AMD/Styx: introduce boolean PCD for KCS/IPMI support
>   Silicon/AMD/Styx/AcpiPlatformDxe: move IPMI/KCS device into separate
>     SSDT
>   Silicon/AMD/Styx/StyxDtbLoaderLib: replace DO_KCS macro reference with
>     PCD
>   Platform/Styx: get rid of DO_KCS preprocessor macro
>   Silicon/AMD/Styx/AcpiPlatformDxe: disable KCS on pre-B1 silicon

Nice bit of cleanup.
Reviewed-by: Leif Lindholm <leif.lindholm at linaro.org>

>  Silicon/AMD/Styx/AmdStyx.dec                  |  1 +
>  .../AMD/OverdriveBoard/OverdriveBoard.dsc     | 15 +-----
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc    |  8 ---
>  .../Overdrive1000Board/Overdrive1000Board.dsc | 10 +---
>  .../AMD/OverdriveBoard/OverdriveBoard.fdf     |  2 -
>  .../Overdrive1000Board/Overdrive1000Board.fdf |  8 ---
>  .../AcpiPlatformDxe/AcpiPlatformDxe.inf       |  3 ++
>  .../Styx/Drivers/PlatInitPei/PlatInitPei.inf  |  1 +
>  .../StyxDtbLoaderLib/StyxDtbLoaderLib.inf     |  2 +
>  .../Drivers/AcpiPlatformDxe/AcpiPlatform.c    | 19 +++----
>  .../Styx/Drivers/PlatInitPei/PlatInitPei.c    | 41 ++++++++-------
>  .../StyxDtbLoaderLib/StyxDtbLoaderLib.c       | 50 ++++++++-----------
>  .../AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 25 ----------
>  .../Styx/Drivers/AcpiPlatformDxe/Iort.aslc    |  8 ---
>  .../Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl  | 47 +++++++++++++++++
>  15 files changed, 108 insertions(+), 132 deletions(-)
>  create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl
> 
> -- 
> 2.19.2
> 


More information about the edk2-devel mailing list