[edk2] [PATCH] ArmPkg: remove redundant _ARM_PLATFORM_FLAGS overrides

Leif Lindholm leif.lindholm at linaro.org
Sat Dec 15 03:03:17 PST 2018


On Sat, Dec 15, 2018 at 09:33:08AM +0100, Ard Biesheuvel wrote:
> Our default is already armv7-a, so no need to rewrite the PLATFORM_FLAGS
> for that. Also, setting -mfpu=neon is not entirely inappropriate, since
> NEON is not mandatory under v7.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm at linaro.org>

> ---
>  ArmPkg/ArmPkg.dsc | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index 495f13d2bbec..5d83c18b143e 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -31,9 +31,6 @@
>    SKUID_IDENTIFIER               = DEFAULT
>  
>  [BuildOptions]
> -  XCODE:*_*_ARM_PLATFORM_FLAGS  == -arch armv7
> -  GCC:*_*_ARM_PLATFORM_FLAGS    == -march=armv7-a -mfpu=neon
> -
>    RELEASE_*_*_CC_FLAGS  = -DMDEPKG_NDEBUG
>    *_*_*_CC_FLAGS  = -DDISABLE_NEW_DEPRECATED_INTERFACES
>  
> -- 
> 2.17.1
> 


More information about the edk2-devel mailing list