[edk2] [PATCH] Platform/FVP-AArch64: switch to the SBSA watchdog

Ard Biesheuvel ard.biesheuvel at linaro.org
Thu Dec 20 03:09:04 PST 2018


On Thu, 20 Dec 2018 at 11:03, Thomas Abraham <thomas.abraham at arm.com> wrote:
>
> On Wed, Dec 19, 2018 at 10:04 PM Leif Lindholm <leif.lindholm at linaro.org> wrote:
> >
> > On Tue, Dec 18, 2018 at 05:46:21PM +0100, Ard Biesheuvel wrote:
> > > On the FVP Foundation model, the SP805 watchdog appears to be 'wired'
> > > incorrectly, resulting in a watchdog counter that decrements at the
> > > APB clock rate of 24 MHz instead of the usual 32 kHz. Since the
> > > timer start value is only 32-bits wide, this makes the watchdog
> > > unusable in UEFI, since the default timeout set by the DXE core is
> > > 5 minutes, which is not representable in 32-bit at this clock rate.
> > >
> > > So switch to the SBSA watchdog instead, which is wired up to the
> > > generic timer, and ticks at the correct rate.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> >
> > From my point of view:
> > Reviewed-by: Leif Lindholm <leif.lindholm at linaro.org>
> >
> > But I'd like a nod from Sami or Thomas (added to cc) as well.
>
> I have not been able test this patch yet but the changes looks fine.
>
> - Thomas.
>

Thanks all

Pushed as  dc6b5ef8a6c2..88e5de1a2346


More information about the edk2-devel mailing list