[edk2] [PATCH v1 0/5] Ues arch-generic API SpeculationBarrier() to replace AsmLfence()

Hao Wu hao.a.wu at intel.com
Thu Dec 20 19:11:01 PST 2018

X86 specific BaseLib API AsmLfence() was introduced to address the Spectre
Variant 1 (CVE-2017-5753) issue. The purpose of this API is to insert
barriers to stop speculative execution. However, the API is highly
architecture (X86) specific, and thus should be avoided using across
generic code.

To address this issue, this series will add a new BaseLib API called
SpeculationBarrier(). Different architectures will have different
implementations for this API. And the series will replace the usage of
AsmLfence() in generic codes with this newly added SpeculationBarrier().

For the implementations of API SpeculationBarrier() among different
architectures, this series will:

* For IA32 and x64, SpeculationBarrier() will directly call AsmLfence().
* For ARM and EBC architectures, an empty implementation is temporarily
  added as a placeholder. We hope experts in those domains can help to
  contribute the actual implementation.

Cc: Ard Biesheuvel <ard.biesheuvel at linaro.org>
Cc: Leif Lindholm <leif.lindholm at linaro.org>
Cc: Liming Gao <liming.gao at intel.com>
Cc: Michael D Kinney <michael.d.kinney at intel.com>
Cc: Jiewen Yao <jiewen.yao at intel.com>
Cc: Laszlo Ersek <lersek at redhat.com>
Cc: Jian J Wang <jian.j.wang at intel.com>
Cc: Star Zeng <star.zeng at intel.com>
Cc: Eric Dong <eric.dong at intel.com>
Cc: Ruiyu Ni <ruiyu.ni at intel.com>

Hao Wu (5):
  MdePkg/BaseLib: Introduce new SpeculationBarrier API
  MdeModulePkg/FaultTolerantWrite: Update to consume SpeculationBarrier
  MdeModulePkg/SmmLockBox: Update to consume SpeculationBarrier
  MdeModulePkg/Variable: Update to consume SpeculationBarrier
  UefiCpuPkg/PiSmmCpuDxeSmm: Update to consume SpeculationBarrier

 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf                      |  2 +-
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf                             |  2 +-
 MdePkg/Library/BaseLib/BaseLib.inf                                                     |  5 +++
 MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h                      | 10 +++---
 MdePkg/Include/Library/BaseLib.h                                                       | 15 +++++++++
 MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.c                   |  8 ++---
 MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.c                                 | 12 ++++----
 MdeModulePkg/Universal/Variable/RuntimeDxe/{LoadFenceDxe.c => SpeculationBarrierDxe.c} | 12 +++++---
 MdeModulePkg/Universal/Variable/RuntimeDxe/{LoadFenceSmm.c => SpeculationBarrierSmm.c} | 14 +++++----
 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c                                  |  6 ++--
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c                               | 24 +++++++--------
 MdePkg/Library/BaseLib/Arm/SpeculationBarrier.c                                        | 30 ++++++++++++++++++
 MdePkg/Library/BaseLib/Ebc/SpeculationBarrier.c                                        | 30 ++++++++++++++++++
 MdePkg/Library/BaseLib/X86SpeculationBarrier.c                                         | 32 ++++++++++++++++++++
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c                                             |  6 ++--
 15 files changed, 163 insertions(+), 45 deletions(-)
 rename MdeModulePkg/Universal/Variable/RuntimeDxe/{LoadFenceDxe.c => SpeculationBarrierDxe.c} (62%)
 rename MdeModulePkg/Universal/Variable/RuntimeDxe/{LoadFenceSmm.c => SpeculationBarrierSmm.c} (61%)
 create mode 100644 MdePkg/Library/BaseLib/Arm/SpeculationBarrier.c
 create mode 100644 MdePkg/Library/BaseLib/Ebc/SpeculationBarrier.c
 create mode 100644 MdePkg/Library/BaseLib/X86SpeculationBarrier.c


More information about the edk2-devel mailing list