[LKP] [patch for-4.20] Revert "mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask"

Linus Torvalds torvalds at linux-foundation.org
Fri Dec 7 14:33:40 PST 2018


On Fri, Dec 7, 2018 at 2:27 PM David Rientjes <rientjes at google.com> wrote:
>
> I noticed the race in 89c83fb539f9 ("mm, thp: consolidate THP gfp handling
> into alloc_hugepage_direct_gfpmask") that is fixed by the revert, but as
> you noted it didn't cleanup the second part which is the balancing act for
> gfp flags between alloc_hugepage_direct_gfpmask() and alloc_pages_vma().
> Syzbot found this to trigger the WARN_ON_ONCE() you mention.

Can you rewrite the commit message to explain this better rather than
the misleading "race" description?

                 Linus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5120 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.01.org/pipermail/lkp/attachments/20181207/99f822b1/attachment.p7s>


More information about the LKP mailing list